AD35XXR: Add/update support to the AD3541R, AD3542R, AD3551R, Ad3552R #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The axi_ad35xx AXI Stream input interface is not defined |
caosjr
force-pushed
the
dev_ad3542r
branch
3 times, most recently
from
1908ba5 to
a62f972
Compare
caosjr
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
LBFFilho,
PopPaul2021,
acostina,
AndreiGrozav and
sarpadi
as code owners
caosjr
changed the title
sarpadi
changed the title
|
Please recreate commits to have: |
sarpadi
reviewed
Jan 17, 2025
Adapted documentation for the axi_ad35xxr to include the four DACs: AD3541R, AD3542R, AD3551R, and AD3552R. Adapted AD355xR_EVB to include information about the AD3551R and AD3552R. Inserted information about the QSPI_SEL pin. Inserted MULTI_IO_MODE reg to the remap of the ad3552r. Signed-off-by: <[email protected]>
It is supporting single SPI (Classic), dual SPI, and Quad SPI (according to the eval limitations) for the DACs AD3541R, AD3542R, AD3551R, AD3552R. Changed the regmap, the reg DAC_CUSTOM_CTRL needs to assert the MULTI_IO_MODE field to choose the SPI mode on the AXI controller. Removed axi_ad3552r library because it was substituted by axi_ad35xxr. Signed-off-by: Carlos Souza <[email protected]>
It is supporting single SPI (Classic), dual SPI, and Quad SPI (according to the eval limitations) for the DACs AD3541R, AD3542R, AD3551R, AD3552R. Removed evaluation board project ad3552r_evb because it was substituted by ad35xxr_evb. Signed-off-by: Carlos Souza <[email protected]>
gastmaier
requested changes
Jan 28, 2025
Comment on lines
154
to
+157
| .. shell:: | ||
|
|
||
| $cd hdl/projects/ad3552r_evb/zed | ||
| $make | ||
| user@analog:~$ cd hdl/projects/ad35xxr_evb/zed | ||
| user@analog:~/hdl/projects/ad35xxr_evb/zed$ make |
There was a problem hiding this comment.
Please respect the syntax: https://analogdevicesinc.github.io/doctools/docs_guidelines.html#shell-directive
this directive is intended to provide a consistent shell snippets to the user, and it makes only the actual command selectable.
|
Please update documentation commit title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Developed a single IP for the AD3552R, AD3551R, AD3542R, and AD3541R parts.
This new IP has support for Single SPI (Classic), Dual SPI, and Quad SPI. It supports
changing the SPI mode during execution by setting the multi_io_mode field.
It was tested the interface file with some modifications on the tb.
Created a documentation for this new IP, and the regmap modification on the axi_ad35xxr.
PR Type
PR Checklist